Skip to content

fix: improved pinia support #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 23, 2024
Merged

fix: improved pinia support #1571

merged 2 commits into from
Aug 23, 2024

Conversation

@nickmessing
Copy link
Member

@nickmessing nickmessing commented Aug 22, 2024

  1. onUnmounted was called in loading tracking
  2. onServerPrefetch only works inside components

@nickmessing nickmessing changed the title Fix pinia bugs fix: apollo usage in pinia Aug 22, 2024
@nickmessing nickmessing changed the title fix: apollo usage in pinia fix: Vue-apollo usage in pinia Aug 22, 2024
@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 22, 2024

commit: 19b0972

@vue/apollo-components

pnpm add https://pkg.pr.new/vuejs/apollo/@vue/apollo-components@1571

@vue/apollo-composable

pnpm add https://pkg.pr.new/vuejs/apollo/@vue/apollo-composable@1571

@vue/apollo-option

pnpm add https://pkg.pr.new/vuejs/apollo/@vue/apollo-option@1571

@vue/apollo-ssr

pnpm add https://pkg.pr.new/vuejs/apollo/@vue/apollo-ssr@1571

@vue/apollo-util

pnpm add https://pkg.pr.new/vuejs/apollo/@vue/apollo-util@1571

Open in Stackblitz

@Akryum Akryum changed the title fix: Vue-apollo usage in pinia fix: improved pinia support Aug 23, 2024
@Akryum Akryum merged commit d329d4d into vuejs:v4 Aug 23, 2024
@nickmessing nickmessing deleted the nick/fix-pinia-bugs branch August 23, 2024 11:37
This was referenced Sep 14, 2024
Closed
Closed
This was referenced Sep 21, 2024
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nickmessing @Akryum